Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `--fast-toc` from cdrdao's options #120

Merged
merged 1 commit into from Feb 4, 2019

Conversation

@Freso
Copy link
Collaborator

commented Nov 1, 2018

In my personal usage --fast-toc almost always results in isrcsubmit.py finding duplicate ISRCs. Removing --fast-toc makes the reading significantly slower, but it also means that it doesn't get duplicate ISRCs meaning it only needs to run once.

Remove `--fast-toc` from cdrdao's options
In my personal usage `--fast-toc` almost always results in isrcsubmit.py
finding duplicate ISRCs. Removing `--fast-toc` makes the reading
significantly slower, but it also means that it doesn't get duplicate
ISRCs meaning it only needs to run once.

@Freso Freso referenced this pull request Nov 12, 2018

Open

Save ISRCs from CD TOC #320

@ulf-noring

This comment has been minimized.

Copy link

commented Feb 2, 2019

Had an issue with a CD where isrcsubmit.py kept reporting multiple tracks sharing the same ISRC, no matter how many times I tried using both cdrdao and libdiscid. This patch solved the issue immediately. Strongly recommend including it, if not as a default then at least as possible flag option when needed.

@JonnyJD JonnyJD merged commit 7f2f5a8 into JonnyJD:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Freso Freso deleted the Freso:remove-cdrdao-fast-toc branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.