Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --fast-toc from cdrdao's options #120

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

Freso
Copy link
Collaborator

@Freso Freso commented Nov 1, 2018

In my personal usage --fast-toc almost always results in isrcsubmit.py finding duplicate ISRCs. Removing --fast-toc makes the reading significantly slower, but it also means that it doesn't get duplicate ISRCs meaning it only needs to run once.

In my personal usage `--fast-toc` almost always results in isrcsubmit.py
finding duplicate ISRCs. Removing `--fast-toc` makes the reading
significantly slower, but it also means that it doesn't get duplicate
ISRCs meaning it only needs to run once.
@ulf-noring
Copy link

Had an issue with a CD where isrcsubmit.py kept reporting multiple tracks sharing the same ISRC, no matter how many times I tried using both cdrdao and libdiscid. This patch solved the issue immediately. Strongly recommend including it, if not as a default then at least as possible flag option when needed.

@JonnyJD JonnyJD merged commit 7f2f5a8 into JonnyJD:master Feb 4, 2019
@Freso Freso deleted the remove-cdrdao-fast-toc branch February 13, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants