Don't assign ISRCs to empty track numbers (cdrdao). #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a release that stores ISRCs both on their own and in the
CD-TEXT, the cdrdao parser would assign the ISRC both to the
trackNumber ("[1, ISRC]"), but also to an empty track ("[None, ISRC]").
This would cause errors on line 658[1] as you cannot add type None
to type Int.
[1] "track = tracks[trackNumber + trackOffset - 1]"
ghost
assigned 
|
We don't need to sanitize the ISRCs taken from the regex, because they are always sanitized by construction. Otherwise your changes are fine and I did an octopus merge (without your sanitization). |
|
Well, the sanitization function was just meant to be a catch-all that future ISRC corrections could be placed in as well. But sure. As long as it's working. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a release that stores ISRCs both on their own and in the CD-TEXT, the cdrdao parser would assign the ISRC both to the trackNumber ("[1, ISRC]"), but also to an empty track ("[None, ISRC]"). This would cause errors on line 658[1] as you cannot add type None to type Int.
[1] "track = tracks[trackNumber + trackOffset - 1]"