Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to provide the mbid of the release as a parameter #65

Merged
merged 1 commit into from
Jun 20, 2013

Conversation

JonnyJD
Copy link
Owner

@JonnyJD JonnyJD commented Jun 13, 2013

Other tools (rippers?) might want to select the correct release in other ways and could then use isrcsubmit for submission semi-automatically.

morituri possibly wants to do it this way.

This is a step between using isrcsubmit "bare" and using python-discid/pymbngs directly.
isrcsubmit still has more backend options and some duplicate/error detection.

Anyways, having this possibility doesn't really hurt.

@ghost ghost assigned JonnyJD Jun 13, 2013
This allows skipping the release choice dialog and selecting
a release with a MusicBrainz ID given as parameter.

The disc ID still has to be attached to the selected release.
@JonnyJD
Copy link
Owner Author

JonnyJD commented Jun 13, 2013

The parameter is called --release-id. The same name is used in morituri.
However, according to thomasvs/morituri#9, there is no actual choice in morituri.

Possibly what is needed is an output of the chosen release_id. That explains the request in #66 to use Disc.get_release() separately.

JonnyJD added a commit that referenced this pull request Jun 20, 2013
see pull-request #65
@JonnyJD JonnyJD merged commit 9a92fb9 into master Jun 20, 2013
@JonnyJD JonnyJD deleted the release_id branch June 20, 2013 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant