New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 bad request using Python 3 (mediatools or discisrc backend) #74

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@JonnyJD
Owner

JonnyJD commented Oct 3, 2013

Using Python 3.3.2 (32 bit) on Windows 7 submission fails:

found new ISRC for track 1: b'GB'b'BBN'b'79'b'02002'
...
ERROR: Couldn't send ISRCs: caused by: HTTP Error 400: Bad Request

I want to note that using Python 2.7 it works on Windows (7) and using Python 3.3.2 it works on Linux.

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Oct 2, 2013

The problem must be somewhere in the parsing of the output of mediatools.exe (which is in the windows binary package of isrcsubmit.py).
Removing mediatools.exe and/or using libdiscid directly (for ISRCs) is a workaround.

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Oct 2, 2013

This isn't actually dependent on the OS. I could reproduce this on Linux with Python 3.3.2 forcing "discisrc" as backend.

However, on Windows mediatools.exe is the default and available, but on Linux all tools normally used (cdrdao, libdiscid) don't work with parsing stdin.

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Oct 2, 2013

This basically means #54 was incomplete.
I made a mistake in 8afa77c.

decode data coming from pipes, fix #74
Decoding only the parsed result wasn't implemented correctly.
We now decode every line coming from the (piped) backends.
This way we can work with unicode already for the parsing.

@ghost ghost assigned JonnyJD Oct 3, 2013

@JonnyJD JonnyJD closed this in 0247569 Oct 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment