Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening a browser from command line on Windows and Mac OS X #77

Merged
merged 3 commits into from
Oct 8, 2013

Conversation

JonnyJD
Copy link
Owner

@JonnyJD JonnyJD commented Oct 5, 2013

Mac OS X doesn't even have safari, Safari or Safari.app in the PATH.
/Applications/Safari.app/Contents/MacOS/Safari seems to work.

Similar on Windows. I can't seem to be able to open Firefox from cmd.
Here it is a bit more difficult, since there isn't a standard path for it either.

@JonnyJD
Copy link
Owner Author

JonnyJD commented Oct 4, 2013

Although I decided against it in #63, maybe using the webbrowser module helps on these platforms to find a browser without using the PATH.

@ghost ghost assigned JonnyJD Oct 5, 2013
@JonnyJD
Copy link
Owner Author

JonnyJD commented Oct 5, 2013

webbrowser.get().open(url) works. webbrowser in general works fine on Windows and Mac.
Like mentioned in the other ticket, having xdg-open installed (Linux) leads to output on stdout. Using webbrowser.get().open() fixes this.

I would still like to have the functionality to provide a browser with an option and using exec where it makes sense.
Additionally, webbrowser has no support for chrom(ium) until Python 3.3.
So I might implement some kind of wrapper and webbrowser as the fallback method 'browser is None'.

JonnyJD added a commit that referenced this pull request Oct 8, 2013
see pull request #77

Conflicts:
	isrcsubmit.py
@JonnyJD JonnyJD merged commit 49a9355 into master Oct 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant