use new libdiscid 0.6.0 device detection if available #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
libdiscid >= 0.6.0 can detect which drive letter is the first cd drive. So we want to use that, rather than just using D: as a default.
JonnyJD
added a commit
that referenced
this pull request
Dec 8, 2013
see pull request #86 Conflicts: isrcsubmit.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows we currently use
D:as default, but starting with libdiscid 0.6.0 the first actual disc drive is detected, which is much more usable.So we should use that.
Cdradao doesn't understand drive letters on Windows, so we should make sure that still works.
I am not really sure if the current code actually works with cdrdao on windows (if drive is
D:then cdrdao is given D as drive letter, but not otherwise?).