New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new libdiscid 0.6.0 device detection if available #86

Merged
merged 1 commit into from Dec 8, 2013

Conversation

Projects
None yet
1 participant
@JonnyJD
Owner

JonnyJD commented Dec 3, 2013

On Windows we currently use D: as default, but starting with libdiscid 0.6.0 the first actual disc drive is detected, which is much more usable.
So we should use that.

Cdradao doesn't understand drive letters on Windows, so we should make sure that still works.
I am not really sure if the current code actually works with cdrdao on windows (if drive is D: then cdrdao is given D as drive letter, but not otherwise?).

@ghost ghost assigned JonnyJD Dec 3, 2013

windows: use libdiscid drive detection if available
libdiscid >= 0.6.0 can detect which drive letter
is the first cd drive. So we want to use that,
rather than just using D: as a default.

JonnyJD added a commit that referenced this pull request Dec 8, 2013

Merge branch 'w32_drive'
see pull request #86

Conflicts:
	isrcsubmit.py

@JonnyJD JonnyJD merged commit 46c47e2 into master Dec 8, 2013

1 check passed

default The Travis CI build passed
Details

@JonnyJD JonnyJD deleted the w32_drive branch Dec 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment