Minor change for out of box Windows support. #41

Merged
merged 1 commit into from Oct 31, 2013

Projects

None yet

2 participants

@clach04
Contributor
clach04 commented Oct 26, 2013

Use default device in readme and example.py

@clach04 clach04 Minor change for out of box Windows support.
Default device in readme and example.py
0b444dc
@JonnyJD
Owner
JonnyJD commented Oct 29, 2013

Well, these are only examples, but yes: many users won't be linux users so we should just skip giving explicit device names in the examples.

/dev/cdrom is a bad example anyways, since that is the default anyways.

@clach04
Contributor
clach04 commented Oct 30, 2013

Do you need me to tweak my changes or can you merge them as-is?

@JonnyJD
Owner
JonnyJD commented Oct 30, 2013

I didn't check very closely yet, but this looks fine.

@JonnyJD JonnyJD added a commit that referenced this pull request Oct 31, 2013
@JonnyJD Merge branch 'win32'
see pull request #41
(make examples usable for non-Linux users)
0454578
@JonnyJD JonnyJD merged commit 0b444dc into JonnyJD:master Oct 31, 2013

1 check passed

default The Travis CI build passed
Details
@JonnyJD
Owner
JonnyJD commented Oct 31, 2013

Merged. Thanks.

I don't have a release date yet and I don't think this is important enough to make another release just now, but this will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment