Fixes bug where child elements all being false still includes object key in className #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developerdizzle
force-pushed
the
ChildElementDuplicateFix
branch
from
adf81cc
to
675de19
Compare
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 13 15 +2
Branches 6 9 +3
=====================================
+ Hits 13 15 +2
Continue to review full report at Codecov.
|
developerdizzle
force-pushed
the
ChildElementDuplicateFix
branch
from
675de19
to
2a43e59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Also refactors/simplifies the logic to force space (" ") to be the separator, and no longer use
prefixas both separator and prefix. This breaks the original "prefix" test, which I've updated to reflect the new functionality. Because this is a breaking change, a major version bump is required.