From 5d46a13b4311c14f3ad5ba508575617d88cc6a5b Mon Sep 17 00:00:00 2001
From: Jorgen Evens <jorgen@evens.eu>
Date: Mon, 6 Feb 2017 23:40:57 +0100
Subject: [PATCH] [apcu] Properly sanitize value of apc key when shown.

---
 cache.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/cache.php b/cache.php
index 7a93019..4c97a89 100644
--- a/cache.php
+++ b/cache.php
@@ -2,7 +2,7 @@
     if (!extension_loaded('apcu')) {
         function apcu_cache_info($limited = false) { return apc_cache_info('user', $limited); }
         function apcu_sma_info($limited = false) { return apc_sma_info($limited); }
-        function apcu_fetch($key, &$success) { return apc_fetch($key, $success); }
+        function apcu_fetch($key, &$success = null) { return apc_fetch($key, $success); }
         function apcu_delete($key) { return apc_delete($key); }
         class ApcuIterator extends ApcIterator {}
     }
@@ -301,7 +301,7 @@ function sort_list(&$list) {
 			<?php if( isset( $_GET['action'] ) && $_GET['action'] == 'apcu_view' ): ?>
 			<div>
 				<h3>Value for <?=htmlentities('"'.$_GET['selector'].'"')?></h3>
-				<pre><?php var_dump( apcu_fetch(urldecode($_GET['selector'])) ); ?></pre>
+				<pre><?=htmlentities(var_export(apcu_fetch(urldecode($_GET['selector']))), true); ?></pre>
 			</div>
 			<?php endif; ?>
 			<?php if( isset( $_GET['action'] ) && $_GET['action'] == 'apcu_select' ): ?>
@@ -311,7 +311,7 @@ function sort_list(&$list) {
 					<thead>
 						<tr>
 							<th><a href="<?=sort_url(has_key(apcu_ref(), 'key', 'info'))?>">Key</a></th>
-							<th><a href="<?=sort_url('nhits')?>">Hits</a></th>
+							<th><a href="<?=sort_url(has_key(apcu_ref(), 'nhits', 'num_hits'))?>">Hits</a></th>
 							<th><a href="<?=sort_url('mem_size')?>">Size</a></th>
 							<th><a href="<?=sort_url('ttl')?>">TTL</a></th>
 							<th>Expires</th>
@@ -327,7 +327,7 @@ function sort_list(&$list) {
 						if( !preg_match(get_selector(), get_key($item, 'key', 'info')) || $expired ) continue;?>
 						<tr>
 							<td><?=get_key($item, 'key', 'info')?></td>
-							<td><?=$item['nhits']?></td>
+							<td><?=get_key($item, 'nhits', 'num_hits')?></td>
 							<td><?=human_size($item['mem_size'])?></td>
 							<td><?=$item['ttl']?></td>
 							<td><?=date('Y-m-d H:i', get_key($item, 'mtime', 'modification_time') + $item['ttl'] )?></td>