New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send confirmation mail if order status is paid #2

Merged
merged 4 commits into from Jan 16, 2018

Conversation

Projects
None yet
3 participants
@khink
Contributor

khink commented Jan 11, 2018

If Mollie would return 'cancelled', then mollie_oscar would cancel the order (as defined in MOLLIE_STATUS_MAPPING). However, a confirmation mail would still be sent.

I'm not sure if this is due to me not understanding how mollie_oscar should work. But this patch does fix it. Or maybe i do not understand correctly how it should work, i'm open to suggestions. Thanks!

khink and others added some commits Jan 11, 2018

Use handle_order_status_change instead of set_status
This gives apps that use this module a chance to customize handling,
for instance to consume / cancel stock allocations.

send_confirmation_message() could (should?) also be done here.
Merge pull request #1 from fourdigits/use-handle-order-status-change
Use handle_order_status_change() instead of direct set_status()

@JorrandeWit JorrandeWit merged commit fc8d8de into JorrandeWit:master Jan 16, 2018

@JorrandeWit

This comment has been minimized.

Owner

JorrandeWit commented Jan 16, 2018

Thanks for the update, this is much better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment