Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.5.7 - Concatentation breaking class names. #104

Closed
TomSequitur opened this issue Apr 26, 2021 · 2 comments · Fixed by #105
Closed

0.5.7 - Concatentation breaking class names. #104

TomSequitur opened this issue Apr 26, 2021 · 2 comments · Fixed by #105
Labels
bug
Milestone
0.5.7.1

Comments

@TomSequitur
Copy link

TomSequitur commented Apr 26, 2021 •
edited
Loading

Describe the bug

As of Version 0.5.7, ocs-sidebar-active- + sidebar_id and ocs-sidebar-location- + sidebar.side are concatenated without a separating space, breaking both class names.

Steps to reproduce the behavior:

  1. Create new sidebar with Location set to Right on OCS v0.5.7.
  2. Assign a widget to sidebar area.
  3. Action sidebar.
  4. See concatenation issue: in my case ocs-sidebar-active-ocs-mobile-navocs-sidebar-location-right.

Expected behavior

Class names concatenated with a space separating: ocs-sidebar-active-ocs-mobile-nav ocs-sidebar-location-right.

Screenshots

screenshot

Specifications

  • Plugin Version: 0.5.7
  • WordPress Version: 5.7.1
  • Other plugins installed: ACF Pro, Debug Bar, Gravity Forms, Regenerate Thumbnails, Simple Custom Post Order, WPFront Scroll Top
  • Theme: Custom, _'s base
  • Browser: Firefox 88.0
  • URL of where the bug occurs: local install only
  • Location of hook placement (header.php and footer.php): immediately after <body> opens and immediately before wp_footer().

Additional context

  • Issue looks to me to appear at line 472 of off-canvas-sidebars.js:
    $html.addClass( 'ocs-sidebar-active ocs-sidebar-active-' + sidebar_id + 'ocs-sidebar-location-' + sidebar.side );

Many thanks for a fantastic plugin, and apologies if this has already been reported. I looked but didn't see any similar issues.

Kind regards,
Tom
@AllWorkNoPlay-95
Copy link
Contributor

AllWorkNoPlay-95 commented Apr 27, 2021 •
edited
Loading

I am having the same issue, i can confirm what TomSequitur described.
Please fix it asap, it's breaking functionality on our site.

UPDATE: i created a pull request for this issue, see request #105.

AllWorkNoPlay-95 added a commit to AllWorkNoPlay-95/off-canvas-sidebars that referenced this issue Apr 27, 2021
@AllWorkNoPlay-95
fixed issue JoryHogeveen#104
2ef9727
@AllWorkNoPlay-95 AllWorkNoPlay-95 mentioned this issue Apr 27, 2021
Merged
JoryHogeveen added a commit that referenced this issue Apr 28, 2021
@JoryHogeveen
Merge pull request #105 from AllWorkNoPlay-95/master
d902ecf 
fixed issue #104
@JoryHogeveen JoryHogeveen added this to the 0.5.8 milestone Apr 28, 2021
@JoryHogeveen
Copy link
Owner

Thanks guys! Merged for the next release :)

@JoryHogeveen JoryHogeveen mentioned this issue Oct 18, 2021
Merged
1 task
@JoryHogeveen JoryHogeveen modified the milestones: 0.5.8, 0.5.7.1 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.5.7.1
Development

Successfully merging a pull request may close this issue.

fixed issue #104 AllWorkNoPlay-95/off-canvas-sidebars
3 participants
@JoryHogeveen @TomSequitur @AllWorkNoPlay-95