Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nofollow to OCS tigger links #116

Closed
inspiredearth opened this issue Aug 22, 2023 · 2 comments
Closed

Add nofollow to OCS tigger links #116

inspiredearth opened this issue Aug 22, 2023 · 2 comments
Assignees
Milestone

Comments

@inspiredearth
Copy link

Description

Describe the solution you'd like
I would like to suggest adding either rel="nofollow" or data-nofollow to the trigger links. Without these, Google's SEO analysis for the site will deduct a few points due to there being links without a valid href. As shown here:

image

Is your feature request related to a problem? Please describe.
The issue is that Google's PageSpeed and SEO analysis doesn't like links without an href attribute. It might have minimal real world impact, but since the solution is so simple, and it will stop Google deducting a few percentage of SEO score, it might as well be implemented.

@JoryHogeveen
Copy link
Owner

JoryHogeveen commented Aug 22, 2023

Hi @inspiredearth

By default the plugin triggers are rendered as a button. If you need an element you can use attr to add extra attributes to your links.

Example:
[ocs_trigger element="a" attr="rel: nofollow"]

As the trigger render is the same for any element what would possible issues be with other elements if I add the rel tag?
Or is the data-nofollow tag 100% sufficient?

Cheers, Jory

@JoryHogeveen JoryHogeveen added this to the 0.5.8 milestone Aug 22, 2023
JoryHogeveen added a commit that referenced this issue Sep 7, 2023
JoryHogeveen added a commit that referenced this issue Sep 7, 2023
@JoryHogeveen JoryHogeveen self-assigned this Sep 7, 2023
@JoryHogeveen
Copy link
Owner

Fixed in 0.5.8

@JoryHogeveen JoryHogeveen mentioned this issue Sep 7, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants