Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.7 #42

Merged
merged 182 commits into from Mar 27, 2017
Merged

v1.7 #42

merged 182 commits into from Mar 27, 2017

Conversation

JoryHogeveen
Copy link
Owner

@JoryHogeveen JoryHogeveen commented Feb 5, 2017

Maintenance:

JoryHogeveen and others added 30 commits January 28, 2017 20:25
- Readme already updated on wp.org
- Remove duplicate code (CodeClimate)
- Improve performance (jQuery selectors
- Improve readability
- Hopefully this works without the need of creating an extra config .xml
… > validate_view_data()

- get_viewAs & set_viewAs marked deprecated (will possibly be removed
soon)
- Also simplify some code
- Add doc comments
- Add/remove whitespaces/newlines
Based on defaults from CodeClimate
- Unnessesary !important
- Simplyfy and improve JS a bit
- Update .eslintrc (higher complexity allowed + jsdoc required)
- eslint: allow alert on CodeClimate (generate warning locally, not
supported by CodeClimate)
No lets hope it also works on TravisCI....
- More API tests
- Improve set users (creation is only needed when the user doesn't
exist)
+ Restructure save_role()
+ Add some inline comments & todos
… on a new line.

Would make it a mess in some cases.
@JoryHogeveen JoryHogeveen merged commit b3dfbdf into master Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant