New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.7 #42
Merged
Merged
v1.7 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Readme already updated on wp.org
- Remove duplicate code (CodeClimate) - Improve performance (jQuery selectors - Improve readability
- Hopefully this works without the need of creating an extra config .xml
This reverts commit 2f4524b.
… > validate_view_data() - get_viewAs & set_viewAs marked deprecated (will possibly be removed soon) - Also simplify some code - Add doc comments - Add/remove whitespaces/newlines
Based on defaults from CodeClimate
- Unnessesary !important - Simplyfy and improve JS a bit - Update .eslintrc (higher complexity allowed + jsdoc required) - eslint: allow alert on CodeClimate (generate warning locally, not supported by CodeClimate)
No lets hope it also works on TravisCI....
…ntly) + PHPdocs etc.
- More API tests - Improve set users (creation is only needed when the user doesn't exist)
Thank you PHP Unit tests :)
+ Restructure save_role() + Add some inline comments & todos
…est doesn't work correctly)
… on a new line. Would make it a mess in some cases.
…for class I do not agree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenance: