Support Duplex Streams for existing_socket #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/client/socksclient.ts
Outdated
| @@ -441,7 +442,7 @@ class SocksClient extends EventEmitter implements SocksClient { | |||
| this.state = SocksClientState.Error; | |||
|
|
|||
| // Destroy Socket | |||
| if (!this._socket.destroyed) { | |||
| if (this._socket instanceof net.Socket && !this._socket.destroyed) { | |||
There was a problem hiding this comment.
Wouldn't we want to call .destroy() on the stream for instances where _socket is not a net.Socket?
There was a problem hiding this comment.
Yeah, I did it kinda bluntly. Fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently existing_socket needs to be an instance of
net.Socket- this is limiting to developers who want to provide a specific stream connected to a proxy server (eg. pre-connected netcat stream).Upon providing such stream, the library can provide SOCKS protocol functionality including authentication.