Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add the option to use old-style cipher padding on public-encryption / private-decryption. #2

Merged
merged 2 commits into from Aug 23, 2012

Conversation

Projects
None yet
2 participants
Contributor

tylerneylon commented Aug 22, 2012

No description provided.

Support old-style padding for public-en/priv.-de.
This adds support for the older RSA_PKCS1_PADDING style
for public encryption and private decryption. This makes ursa more
compatible with other crypto systems.

Rather than do default logic at the low layer, I'd prefer to do it up at the JS level, a la:

padding = padding || ursaNative. RSA_PKCS1_OAEP_PADDING;

Pretty much, if something can be done in JS I'll aim to actually do it there, at least vaguely for reasons along the lines of consistency, code safety, and conciseness.

See above.

See above.

Other than the one comment, LGTM.

Contributor

danfuzz commented Aug 23, 2012

Looks great. Thanks!

danfuzz added a commit that referenced this pull request Aug 23, 2012

Merge pull request #2 from tylerneylon/master
Add the option to use old-style cipher padding on public-encryption / private-decryption.

@danfuzz danfuzz merged commit 33235e2 into JoshKaufman:master Aug 23, 2012

Contributor

danfuzz commented Aug 23, 2012

New version pushed to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment