Added "features" option to genius_url #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! really cool project. Haven't used github too much, so sorry for any sloppiness. Added a "features" argument to genius_url to track Genius information on songs with multiple vocalists. Two new columns, "vocalist" and "verse", detail the artist for each verse and their lyrics. All other keyword arguments remain the same. I also NAMESPACE to include needed functions.
added some required functions to genius_url
Update NAMESPACE for "features" in genius_url
Added "features" option to genius_url
|
You're a hero. I've been trying to figure out how to do this for a long while and honestly partially gave up a while back. I'm currently finish finals and traveling tomorrow. Will review and merge by the beginning of next week. |
|
addresses issue #4 |
|
Merged. Thank you for your contributions!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! really cool project. Haven't used github too much, so sorry for any sloppiness. Added a "features" argument to genius_url to track Genius information on songs with multiple vocalists. Two new columns, "vocalist" and "verse", detail the artist for each verse and their lyrics. All other keyword arguments remain the same.
I also updated NAMESPACE to include needed functions.