Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Title when using REGISTRY_URL (feature request) #28

Closed
soosap opened this issue Feb 16, 2018 · 1 comment

Comments

@soosap
Copy link

commented Feb 16, 2018

Hi I have tested the app using the fix suggested by #27. First of all, I can confirm that the PR solves the problem.

Yet another small issue arises when using REGISTRY_URL: No title is being set.

screen shot 2018-02-17 at 00 12 31

Would it be possible to pass a custom name via an optional environment variable i.e. REGISTRY_TITLE?

Thanks for considering :)

@Joxit Joxit self-assigned this Feb 18, 2018

@Joxit Joxit added this to To do in docker-registry-ui Feb 18, 2018

@Joxit Joxit added the enhancement label Mar 3, 2018

@Joxit Joxit moved this from To do to In progress in docker-registry-ui Mar 3, 2018

Joxit added a commit that referenced this issue Mar 11, 2018

Merge pull request #32 from Joxit/feat/add-title-docker-static
[feat #28] Add Title when using `REGISTRY_URL` …
@Joxit

This comment has been minimized.

Copy link
Owner

commented Mar 22, 2018

Done in #32 (v0.3.4)
Use REGISTRY_TITLE to set your custom title 😄
Thanks again ;)

@Joxit Joxit closed this Mar 22, 2018

docker-registry-ui automation moved this from In progress to Done Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.