Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke /app/docker-entrypoint.sh when reloading nginx-proxy #401

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
2 participants
@thomseddon
Copy link
Contributor

commented Jun 14, 2018

The /app/docker-entrypoint.sh within nginx-proxy sets the RESOLVERS environment variable, so when docker-proxy is invoked without it the resolvers aren't set in the nginx config.

The more general problem, which this PR doesn't fix, is that all other environment variables are also clobbered when the config is generated by these means.
Unfortunately, as docker-gen is run via forego within docker-proxy, a HUP signal sent to the docker-proxy container won't be passed through (it just kills the container). I think the actual fix here is probably to change the handling of HUP's within forego?

Might also be worth a note in the README as it took me ages to work out why this environment variable seemed not to be set sometimes...

@buchdag

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2018

The docker_api test unit has to be modified to take your changes into account.

@thomseddon

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2018

:) So I see! Just fixing now.

@thomseddon

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2018

Done :)

@buchdag

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2018

LGTM, thanks for this PR !

@buchdag buchdag merged commit fa5baf5 into JrCs:master Jun 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

buchdag added a commit that referenced this pull request Jun 14, 2018

Silence docker_exec noisy output after #401
Going through /app/docker-entrypoint.sh in the nginx-proxy
container generate some unneeded noise to std out.

buchdag added a commit that referenced this pull request Jul 7, 2018

Silence docker_exec noisy output after #401
Going through /app/docker-entrypoint.sh in the nginx-proxy
container generate some unneeded noise to std out.

buchdag added a commit that referenced this pull request Jul 8, 2018

Silence docker_exec noisy output after #401 (#402)
Going through /app/docker-entrypoint.sh in the nginx-proxy
container generate some unwanted noise to std out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.