Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode path to /app/letsencrypt_service_data #404

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
2 participants
@buchdag
Copy link
Collaborator

commented Jun 14, 2018

This is an attempt to fix #396 ("attempt to fix" because the circumstances under which the issue happen seems to be rather hard to reproduce reliably, so additional confirmation will be required).

From what I found, under those undetermined circumstances the $DIR variable ends up being empty, so the update_certs function returns without doing anything.

Considering the limited use of this variable and the fact that /app is already hardcoded in a lot of places, I think the safest fix is to hardcode the path /app/letsencrypt_service_data.

@buchdag buchdag requested a review from JrCs Jun 14, 2018

@JrCs

JrCs approved these changes Jun 15, 2018

@buchdag buchdag merged commit 09ade6f into master Jun 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@buchdag buchdag deleted the fix-396 branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.