Mimics ActiveRecord behavior when destroying resource #314
Conversation
* Add `destroyed?` method * Return false on `persisted?` * Do not clear resource attributes Co-authored-by: Gabriel Reis <gabriel@hashrocket.com>
lib/json_api_client/resource.rb
Outdated
| else | ||
| self.attributes.clear | ||
| mark_as_destroyed! | ||
| self.relationships.attributes.clear |
There was a problem hiding this comment.
if we don't want to clear attributes after destroy, why we should clear relationships?
Co-authored-by: Mary Lee <mary.lee@hashrocket.com> Co-authored-by: Gabriel Reis <gabriel@hashrocket.com>
gaorlov
left a comment
gaorlov
left a comment
There was a problem hiding this comment.
That looks great! Thanks a ton for the PR and the work.
| user = users.first | ||
| assert(user.persisted?) | ||
| assert_equal(false, user.new_record?) | ||
| assert_equal(false, user.destroyed?) |
There was a problem hiding this comment.
You can also do refute user.new_record?, but it really doesn't matter
There was a problem hiding this comment.
We can change it if you'd like; we were just trying to follow the style of the existing tests. Do you want us to update?
There was a problem hiding this comment.
Hi 👋, recently I played with Rubocop. It suggests to use ActiveSupport method assert_not
assert_not user.new_record?PS: more than one way of doing the same thing 😏 Its up to commits author, what to use.
There was a problem hiding this comment.
@hashrocketeer, nah. Thanks again for the contribution! I'll push out a new version with your code by eod.
|
@hashrocketeer |
4 participants
destroyed?methodpersisted?after being destroyednew_record?after being destroyed