New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to complete the ASP.NET Core integration package #6

Closed
JuergenGutsch opened this Issue Jul 11, 2017 · 1 comment

Comments

2 participants
@JuergenGutsch
Owner

JuergenGutsch commented Jul 11, 2017

We need to complete the ASP.NET Core integration package to get it running in ASP.NET Core and .NET Core

  • Needs some more time, because it needs a generic and proper way to move the existing service registrations from the ASP.NET Core's IServiceCollection to LightCore
  • The current implementation doesn't catch two pretty special service registrations from the IServiceCollection to LightCore, which are the following:

{System.Collections.Generic.IEnumerable1[Microsoft.Extensions.Options.IConfigureOptions1[Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerOptions]] setups}

{System.Collections.Generic.IEnumerable1[Microsoft.Extensions.Options.IPostConfigureOptions1[Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerOptions]] postConfigures}

e.g.

using Microsoft.Extensions.Options;
using Microsoft.AspNetCore.Server.Kestrel.Core;

IEnumerable<IConfigureOptions<KestrelServerOptions>>
IEnumerable<IPostConfigureOptions<KestrelServerOptions>>

@JuergenGutsch JuergenGutsch added this to the 2.0.0-preview1 milestone Jul 11, 2017

@JuergenGutsch JuergenGutsch added this to To do in Integrations Jul 11, 2017

@JuergenGutsch JuergenGutsch moved this from To do to In progress in Integrations Jul 11, 2017

JuergenGutsch added a commit that referenced this issue Mar 28, 2018

peterbucher added a commit that referenced this issue Mar 30, 2018

@peterbucher

This comment has been minimized.

Show comment
Hide comment
@peterbucher

peterbucher Mar 30, 2018

Collaborator

@JuergenGutsch We can close this issue now?

Collaborator

peterbucher commented Mar 30, 2018

@JuergenGutsch We can close this issue now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment