fix(deploy): pass commit message via env var (multi-line safe)#42
Merged
Conversation
GitHub Actions expansion of multi-line strings into a shell argument like
--commit-message="${{ github.event.head_commit.message }}" splits on
newlines and wrangler reads the trailing lines as positional arguments
("Unknown arguments: …"). Pass the message via an env var instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions expanding a multi-line commit message directly into a shell argument breaks wrangler. Switching to an env var fixes it.
Previously failed run example: JuiceSwapxyz/documentation run 26468813723 ("Unknown arguments: requires, at, least, Node.js, v22.0.0"). Same bug in all 5 docs repos.