handle printing of non-number coefficients #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
reviewed
Mar 3, 2018
test/show.jl
Outdated
| @test sprint(show, -(1.0 + 3.1im) * z*x) == "(-1.0 - 3.1im)xz" | ||
| @test sprint(show, x^2 + (1.0 + 3.1im) * x) == "x^2 + (1.0 + 3.1im)x" | ||
| @test sprint(show, x^2 - (1.0 + 3.1im) * x) == "x^2 + (-1.0 - 3.1im)x" | ||
| @test sprint(show, [1.0, 2.0] * x == "([1.0, 2.0])x") |
Member
There was a problem hiding this comment.
The parenthesis at the end should be between x and ==
Collaborator
Author
There was a problem hiding this comment.
Whoops, good catch. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 79.19% 79.27% +0.07%
==========================================
Files 16 16
Lines 519 521 +2
==========================================
+ Hits 411 413 +2
Misses 108 108
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polynomials with vector coefficients work just fine, but they can't be displayed because we end up trying to call
one(::Vector)just to decide whether to print that coefficient. This PR just makes sure we only useisoneforNumbers and just print everything else.