Example - Gravities of the Solar System #432
Conversation
There was a problem hiding this comment.
The animation looks awesome! Thanks for creating the PR. I think we should try to use act! to update the positions of each planet though instead of creating new objects every time.
You can find some examples and explanations regarding that in my latest blog posts: https://opensourc.es
Let us know when you have any questions.
|
My bad I forgot the pr wasn't a draft, definitely still some work to be done before it's ready. I've been struggling to do this in an example-worthy way without something to properly represent forces like #423. I also think this would be a great example to put out with forces to showcase how they work. I'm curious about opinions on if I should wait for #423 to be implemented before finishing this animation. @Wikunia I feel pretty confident that I could implement #423 I just want to look into the internals of Javis a little more before I commit to doing it. |
|
I think in the long run we definitely want to have #423 in this example. However it might make sense to try it out without it first and learn the best approach of how to make it internal later on. |
|
As an additional comment, I would say that #423 would be best to go into another Javis package called something like JavisPhysics. Now since we have the JuliaAnimators organization, we could go ahead and create that repository to handle prototyping of these ideas that are more domain specific. |
I was thinking of suggesting making it its own package as well. Being an engineer might make me think too big for the intended use case in Javis, but I think either keep the scope of physics/forces to how it's currently outlined in #423, and if users want to do something more complicated, they can do a for loop like my original PR. Otherwise, feature creep related to physics could get pretty excessive and would warrant its own package. |
|
Hey people. This PR Looks really solid!
I can't agree more @Wikunia. Before having some rigid math/physics/any computational stuff it would be better to have multiple examples before hand. We could divide and exand the examples sections though(based on domain). Also I would love to see how we can possibly integrate other physics based/domain specific packages from the julia package ecosystem since those will be much more performant and also save us time. |
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
- Coverage 96.19% 96.18% -0.02%
==========================================
Files 36 36
Lines 1604 1598 -6
==========================================
- Hits 1543 1537 -6
Misses 61 61
Continue to review full report at Codecov.
|
PR Checklist
If you are contributing to
Javis.jl, please make sure you are able to check off each item on this list:CHANGELOG.mdwith whatever changes/features I added with this PR?Project.toml+ set an upper bound of the dependency (if applicable)?testdirectory (if applicable)?Link to relevant issue(s)
Closes #360
How did you address these issues with this PR? What methods did you use?
Not sure if you would like to bump the version in the
CHANGELOG.mdjust for an example.Otherwise, the code in this PR is just for a new example. The example has been added to the repos
/examplesfolder as well as the Examples in the docs. Below is an example of the finished animation!