introduce function collect_as for construction from an iterator
#48
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 98.91% 98.36% -0.56%
==========================================
Files 1 1
Lines 92 183 +91
==========================================
+ Hits 91 180 +89
- Misses 1 3 +2 ☔ View full report in Codecov by Sentry. |
Makes constructing `FixedSizeArray`s more convenient! Inspired by JuliaLang/julia#36288 This currently ignores `Base.IteratorElType`, xref https://discourse.julialang.org/t/i-dont-get-base-iteratoreltype/113604 The allocations in some code paths are probably excessive/could be optimized. But I guess this is good for a start. Fixes #20
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
Since this is a new user-facing function, maybe it should be documented at least in the README? We can also set up proper docs
One of these wasn't being recorded by code coverage (another Julia coverage bug, I guess).
| # helper functions | ||
|
|
||
| dimension_count_of(::Base.SizeUnknown) = 1 | ||
| dimension_count_of(::Base.HasLength) = 1 |
There was a problem hiding this comment.
Last line still not covered (unless it's another coverage bug?)
There was a problem hiding this comment.
Yeah, it's JuliaLang/julia#54214 again. I guess this form is buggy:
f(::SingletonType) = isbits_literalThere was a problem hiding this comment.
So it isn't just empty tuple but any singleton?
There was a problem hiding this comment.
I did check that these lines are in actuality covered by the tests, by replacing 1 with error().
2 participants
Makes constructing
FixedSizeArrays more convenient!Inspired by
JuliaLang/julia#36288
This currently ignores
Base.IteratorElType, xref https://discourse.julialang.org/t/i-dont-get-base-iteratoreltype/113604The allocations in some code paths are probably excessive/could be optimized. But I guess this is good for a start.
Fixes #20