Implement Base.unsafe_wrap for OffsetArrays (pull request) #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
reviewed
May 22, 2022
Member
timholy
left a comment
timholy
left a comment
There was a problem hiding this comment.
The implementation is excellent, only one tiny change to request.
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 95.55% 95.67% +0.12%
==========================================
Files 5 5
Lines 427 439 +12
==========================================
+ Hits 408 420 +12
Misses 19 19
Continue to review full report at Codecov.
|
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #275