Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unitful quantities: either reexport units or clarify docs? #37

Closed
stillyslalom opened this issue Dec 16, 2020 · 1 comment · Fixed by #39
Closed

Unitful quantities: either reexport units or clarify docs? #37

stillyslalom opened this issue Dec 16, 2020 · 1 comment · Fixed by #39

Comments

@stillyslalom
Copy link

ref. https://discourse.julialang.org/t/how-to-use-units-in-cosmology-jl/51935/2, this package includes several examples in its documentation which require Unitful and UnitfulAstro to run. Those requirements should either be made clear in the documentation, or the relevant parts of Unitful/UnitfulAstro should be re-exported from here.

@giordano
Copy link
Member

I'm not personally happy about re-exporting stuff (even though I can see why it'd be useful here). An improvement to documentation is definitely warranted. Pull requests are welcome 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants