Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable UTF check when creating input data #212

Merged
merged 1 commit into from
Jun 26, 2018
Merged

disable UTF check when creating input data #212

merged 1 commit into from
Jun 26, 2018

Conversation

KristofferC
Copy link
Contributor

@KristofferC KristofferC commented Jun 26, 2018 •
edited
Loading

Should fix loading the problem dataset taking forever.

Note that this doesn't change any benchmark, just makes creating the input data set faster.

@KristofferC
Copy link
Contributor Author

loading group "problem"... done (took 3.460583769 seconds)

nalimilan
nalimilan approved these changes Jun 26, 2018
View reviewed changes
Copy link
Collaborator

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an official way to do this, but for now if that can fix CI on 0.7...

@KristofferC
Copy link
Contributor Author

Yeah, I just see this as a CI unbreaker.

@KristofferC KristofferC merged commit 89a49ed into master Jun 26, 2018
@KristofferC KristofferC removed the request for review from ararslan June 26, 2018 12:29
@nalimilan nalimilan deleted the kc/no_check branch June 26, 2018 12:41
@KristofferC KristofferC mentioned this pull request Jul 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristofferC @nalimilan