This repository was archived by the owner on Feb 25, 2024. It is now read-only.
Switch march to mcpu for ARM #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
suggested changes
Apr 28, 2020
|
|
||
| # Add MCPU to flags | ||
| if not mcpu is None: | ||
| flags += "MCPU=%s "%(mcpu) |
Member
There was a problem hiding this comment.
I don't think the Julia buildsystem uses MCPU, does it? We have MARCH defined, but there's no hint of MCPU anywhere. I think you'd need to plumb it through down here to be added to the compiler invocations: https://github.com/JuliaLang/julia/blob/86ee57cdd77d402ea63108c16df7117d0ce83dc7/Make.inc#L820-L822
Member
Author
There was a problem hiding this comment.
Yeah, sorry forgot to link the PR I did here JuliaLang/julia#35617
Co-Authored-By: Elliot Saba <staticfloat@gmail.com>
Member
Author
|
Corresponding changes in base to support MCPU during build JuliaLang/julia#35617 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #148
cc. @staticfloat