[windows] Upload .zip files
#245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This should solve issues like the one reported here: https://discourse.julialang.org/t/julia-nightly-is-27-days-old/90054 |
DilumAluthge
approved these changes
Nov 14, 2022
Member
DilumAluthge
left a comment
DilumAluthge
left a comment
There was a problem hiding this comment.
Is there a reason that we use PowerShell to create the .zip file, instead of using 7zip or something else that we already have lying around?
But LGTM regardless.
Member
Author
|
Because if we stop shipping p7zip, this will keep on working. |
DilumAluthge
added
the
automerge
Member
|
In hindsight we should have gotten this in before 1.8.3. |
Member
|
At least it will be in 1.8.4 (once I backport this PR to the |
We need to serve not only `.tar.gz` files, but `.zip` files as well, as many windows users do not have an easy way to extract tarballs.
DilumAluthge
force-pushed
the
sf/windows_upload_zip_files
branch
from
97725f0 to
2a4c5dd
Compare
DilumAluthge
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to serve not only
.tar.gzfiles, but.zipfiles as well, as many windows users do not have an easy way to extract tarballs.