[REVIEW]: Dionysos.jl: a Modular Platform for Smart Symbolic Control

[editorialbot]

Submitting author: @adrienbanse (Adrien Banse)
Repository: https://github.com/dionysos-dev/Dionysos.jl
Branch with paper.md (empty if default branch):
Version: v0.1.3
Editor: @lucaferranti
Reviewers: @schillic, @jmskov
Archive: 10.5281/zenodo.14421121

Status

Status badge code:

HTML: <a href="https://proceedings.juliacon.org/papers/645b14c7e9e951673b26b6d8319d3058"><img src="https://proceedings.juliacon.org/papers/645b14c7e9e951673b26b6d8319d3058/status.svg"></a>
Markdown: [![status](https://proceedings.juliacon.org/papers/645b14c7e9e951673b26b6d8319d3058/status.svg)](https://proceedings.juliacon.org/papers/645b14c7e9e951673b26b6d8319d3058)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@schillic & @jmskov, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lucaferranti know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @jmskov

📝 Checklist for @schillic

[editorialbot]

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper source files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.20 s (1097.0 files/s, 173101.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                          163           2752           2289          19984
TeX                              9            388            270           3131
XML                              7            167             66           1725
CSV                              2              0              0           1676
Markdown                        17            236              0            700
TOML                             6             11              1            189
YAML                             7              7              5            182
Lisp                             2             16              0             69
Ruby                             1              8              4             45
CSS                              1              0              0              4
-------------------------------------------------------------------------------
SUM:                           215           3585           2635          27705
-------------------------------------------------------------------------------

Commit count by author:

    75	Benoît Legat
    64	guberger
    57	adrienbanse
    39	Julien Calbert
    34	labo-admin
    31	github-actions[bot]
    30	Lucas Egidio
    24	Adrien Banse
    16	vdebauche
    15	CompatHelper Julia
    15	Guillaume Berger
    10	7380Xing
     7	Virginie Debauche
     5	JulienCalbert
     3	MDella92
     2	Zheming Wang
     1	Arnaud Browet
     1	Davide De Lazzari
     1	DeligneS
     1	Mahsa Farjadnia
     1	SMattenet
     1	Thiago Alves Lima
     1	ThiagoAlvesLima
     1	aaspeel
     1	raphaeljungers
     1	somyasingh711995
     1	vuille5

[editorialbot]

Paper file info:

📄 Wordcount for paper.tex is 5585

🔴 Failed to discover a Statement of need section in paper

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s12532-023-00239-3 is OK
- 10.1016/s0005-1098(98)00178-2 is OK
- 10.48550/ARXIV.2401.04068 is OK
- 10.48550/ARXIV.2401.03555 is OK
- 10.1145/1967701.1967748 is OK
- 10.5281/ZENODO.10460005 is OK
- 10.1109/tac.2013.2295664 is OK
- 10.24433/CO.6327570.V2 is OK
- 10.48550/ARXIV.2403.09556 is OK
- 10.1145/1967701.1967730 is OK

MISSING DOIs

- 10.1109/jproc.2012.2189792 may be a valid DOI for title: Cyber–physical systems: A perspective at the cente...
- No DOI given, and none found for title: Principles of cyber-physical systems
- No DOI given, and none found for title: Introduction to embedded systems: A cyber-physical...
- No DOI given, and none found for title: Principles of model checking
- No DOI given, and none found for title: Verification and control of hybrid systems: a symb...
- 10.1007/bfb0055622 may be a valid DOI for title: Alternating refinement relations
- No DOI given, and none found for title: Feedback refinement relations for the synthesis of...
- No DOI given, and none found for title: Formal methods for discrete-time dynamical systems
- No DOI given, and none found for title: Model checking of safety properties
- 10.1109/9.989067 may be a valid DOI for title: A Lyapunov approach to incremental stability prope...
- 10.1016/s0005-1098(98)00019-3 may be a valid DOI for title: On contraction analysis for non-linear systems
- 10.1109/cdc.2011.6160424 may be a valid DOI for title: Safety controller synthesis for switched systems u...
- 10.1145/3178126.3178143 may be a valid DOI for title: Multi-layered abstraction-based controller synthes...
- No DOI given, and none found for title: Safety controller synthesis for incrementally stab...
- 10.1007/978-3-642-00602-9_25 may be a valid DOI for title: Discrete-state abstractions of nonlinear systems u...
- 10.1007/978-3-642-14295-6_49 may be a valid DOI for title: Pessoa: A tool for embedded controller synthesis
- No DOI given, and none found for title: SCOTS: A tool for the synthesis of symbolic contro...
- No DOI given, and none found for title: Design of symbolic controllers for networked contr...
- 10.1007/978-3-540-78929-1_15 may be a valid DOI for title: Approximately bisimilar symbolic models for increm...
- No DOI given, and none found for title: CoSyMA: a tool for controller synthesis using mult...
- 10.1145/136035.136043 may be a valid DOI for title: Symbolic boolean manipulation with ordered binary-...
- 10.1016/j.automatica.2005.08.007 may be a valid DOI for title: Barrier certificates for nonlinear model validatio...
- 10.1007/978-3-540-24743-2_32 may be a valid DOI for title: Safety verification of hybrid systems using barrie...
- 10.1109/cdc45484.2021.9683448 may be a valid DOI for title: Alternating simulation on hierarchical abstraction...
- No DOI given, and none found for title: Abstraction-based branch and bound approach to Q-l...
- 10.1109/cdc51059.2022.9992495 may be a valid DOI for title: State-feedback abstractions for optimal control of...
- No DOI given, and none found for title: Data-driven memory-dependent abstractions of dynam...
- 10.23919/acc55779.2023.10156175 may be a valid DOI for title: Data-driven heuristic symbolic models and applicat...
- 10.1109/lcsys.2024.3409106 may be a valid DOI for title: Smart abstraction based on iterative cover and non...
- No DOI given, and none found for title: Reachability analysis and its application to the s...
- No DOI given, and none found for title: JuliaReach: a toolbox for set-based reachability
- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing
- 10.1287/ijoc.2021.1067 may be a valid DOI for title: MathOptInterface: a data structure for mathematica...

INVALID DOIs

- None

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[lucaferranti]

Thank you @adrienbanse for the submission and @schillic and @jmskov for volunteering as reviewers. I will be the editor for this submission.

Reviewers, as first, you can generate your checklist with

@editorialbot generate my checklist

After that, feel free to leave your review comments either here or as issues in the submission repository. You can find more information in the review guide and feel free to ping me at any time if you have questions.

[jmskov]

Review checklist for @jmskov

Conflict of interest

• I confirm that I have read the JuliaCon conflict of interest policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JCon for the purpose of this review.

Code of Conduct

• I confirm that I read and will adhere to the JuliaCon code of conduct.

General checks

• Repository: Is the source code for this software available at the https://github.com/dionysos-dev/Dionysos.jl?
• License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
• Contribution and authorship: Has the submitting author (@adrienbanse) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Paper format

• Authors: Does the paper.tex file include a list of authors with their affiliations?
• A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
• References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Content

• Context: is the scientific context motivating the work correctly presented?
• Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
• Results: are the results presented and compared to approaches with similar goals?

[adrienbanse]

@editorialbot commands