Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: TSML (Time Series Machine Learning) #51

Open
whedon opened this issue Sep 6, 2019 · 87 comments
Assignees
Labels
Milestone

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Sep 6, 2019

Submitting author: @ppalmes (Paulito Palmes)
Repository: https://github.com/IBM/TSML.jl
Editor: @matbesancon
Reviewer: @christianpeel, @theogf
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://submissions.juliacon.org/papers/9b3cd0a6095ca4e2d61cfe1efaa2966a"><img src="https://submissions.juliacon.org/papers/9b3cd0a6095ca4e2d61cfe1efaa2966a/status.svg"></a>
Markdown: [![status](https://submissions.juliacon.org/papers/9b3cd0a6095ca4e2d61cfe1efaa2966a/status.svg)](https://submissions.juliacon.org/papers/9b3cd0a6095ca4e2d61cfe1efaa2966a)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@christianpeel & @theogf, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/JuliaCon/proceedings-reviews/invitations

The reviewer guidelines are available here: https://proceedings.juliacon.org/guide/reviewers. Any questions/concerns please let @matbesancon know.

Please try and complete your review in the next two weeks

Review checklist for @christianpeel

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Authorship: Has the submitting author (@ppalmes) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Paper format

  • Authors: Does the paper.tex file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
  • Page limit: Is the page limit for full papers respected by the submitted document?

Content

  • Context: is the scientific context motivating the work correctly presented?
  • Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
  • Results: are the results presented and compared to approaches with similar goals?

Review checklist for @theogf

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Authorship: Has the submitting author (@ppalmes) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Paper format

  • Authors: Does the paper.tex file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
  • Page limit: Is the page limit for full papers respected by the submitted document?

Content

  • Context: is the scientific context motivating the work correctly presented?
  • Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
  • Results: are the results presented and compared to approaches with similar goals?
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 6, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @christianpeel, @theogf it looks like you're currently assigned to review this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/JuliaCon/proceedings-review) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/JuliaCon/proceedings-review:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 6, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 6, 2019

PDF failed to compile for issue #51 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/51 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Sep 6, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 6, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 6, 2019

PDF failed to compile for issue #51 with the following error:

sh: 1: cd: can't cd to tmp/51
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/51 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Sep 6, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 6, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 6, 2019

PDF failed to compile for issue #51 with the following error:

sh: 1: cd: can't cd to tmp/51
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/51 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Sep 6, 2019

@ppalmes there is an error in the build, does it work locally?

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Sep 12, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 12, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 12, 2019

PDF failed to compile for issue #51 with the following error:

sh: 1: cd: can't cd to tmp/51
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/51 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Sep 12, 2019

@matbesancon, it works here #42

maybe, you should fix again the pointer as you did before in #42?

you replied to me in #42 thread: "it was in the submission repo, the whole /tree/master/paper path was not needed"

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Sep 12, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 12, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 12, 2019

PDF failed to compile for issue #51 with the following error:

sh: 1: cd: can't cd to tmp/51
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/51 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Sep 12, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 12, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 12, 2019

PDF failed to compile for issue #51 with the following error:

sh: 1: cd: can't cd to tmp/51
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/51 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-61fc68877343/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Sep 12, 2019

final version in pre-review: #42 (comment)

@JuliaCon JuliaCon deleted a comment from whedon Sep 19, 2019
@JuliaCon JuliaCon deleted a comment from whedon Sep 19, 2019
@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Sep 19, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 19, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Sep 19, 2019

@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Sep 19, 2019

@theogf @christianpeel you can continue the review here

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 22, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 22, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 22, 2019

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 23, 2019

Hi @matbesancon , let me know if the changes are ok.

@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Oct 23, 2019

@matbesancon matbesancon added this to the Issue 1 milestone Oct 24, 2019
@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Oct 24, 2019

@ppalmes in the changes you made, there is a point with filter's which should be pluralized -> filters' or with pronoun I think "the filter's"

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 24, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 24, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 24, 2019

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 24, 2019

Hi @matbesancon, I think pluralized is ok because I'm talking about all the filters. I made the change and you can check above the proof.

@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Oct 24, 2019

ok, this paper looks good, thanks @christianpeel, @theogf!

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 29, 2019

@matbesancon, @christianpeel, @theogf

thanks all! highly appreciate the suggestions and corrections.

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 29, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 29, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 29, 2019

PDF failed to compile for issue #51 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon.rb:190:in block in parse_authors': Author (Paulito Palmes) is missing affiliation (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon.rb:188:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon.rb:188:in parse_authors' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon.rb:91:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 29, 2019

hi @matbesancon, i just added a missing period at the end of a statement in the first paragraph of section 2 but the paper did not compile above.

@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Oct 29, 2019

i think there is an error in the YAML file, the affiliation is broken

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 29, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 29, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 29, 2019

PDF failed to compile for issue #51 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon.rb:190:in block in parse_authors': Author (Paulito Palmes) is missing affiliation (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon.rb:188:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon.rb:188:in parse_authors' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon.rb:91:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-74bc29a6a731/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 29, 2019

@matbesancon, i haven't touched or edited paper.yml. my last git commit editing it was Aug 27. I don't know why this error appeared recently when my paper.yml used to work before. The affiliation stub is there.

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 29, 2019

@whedon generate pdf from branch juliacon2019-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 29, 2019

Attempting PDF compilation from custom branch juliacon2019-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 29, 2019

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Oct 29, 2019

@matbesancon , apparently there was changes to the parsing of yml. I added affiliation index which now works but since all of us are in the same company, it doesn't make sense to have this index on in the affiliation.

@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Oct 30, 2019

perfect thanks. Yes that's just the way the YAML is parsed, otherwise it adds special cases

@ppalmes

This comment has been minimized.

Copy link

@ppalmes ppalmes commented Nov 6, 2019

@matbesancon , when is the expected date of publication? thanks.

@matbesancon

This comment has been minimized.

Copy link
Member

@matbesancon matbesancon commented Nov 6, 2019

In a few weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.