(actually) use hessenberg factorization for statespace freqresp #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something failed when generating plots. See the log at https://github.com/JuliaControl/ControlExamplePlots.jl/actions/runs/1686630449?check_suite_focus=true for more details. |
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
+ Coverage 85.28% 85.68% +0.39%
==========================================
Files 31 31
Lines 3188 3200 +12
==========================================
+ Hits 2719 2742 +23
+ Misses 469 458 -11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks show it's quite a lot faster than the previous
freqresp. The new version is labelled "large" because I had originally intended to use it for large systems only, but it turned out to be faster across the board. The benchmark is performed on a 2x2 system with varying order of the state, evaluating the freqresp on 200 frequency points.