make numbers and matrices work as systems in freqresp and friends
#630
Conversation
this is convenient in many places where functions that take either systems of gain matrices.
baggepinnen
changed the title
freqrespfreqresp and friends
|
This is an automated message.
|
|
This is an automated message.
|
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
+ Coverage 86.66% 86.69% +0.02%
==========================================
Files 31 31
Lines 3233 3240 +7
==========================================
+ Hits 2802 2809 +7
Misses 431 431
Continue to review full report at Codecov.
|
albheim
left a comment
albheim
left a comment
There was a problem hiding this comment.
Looks good, also noted that the docstring for freqresp had w -> ... iw*im ... which I assume should be I*w*im? Not really related, just thought I could mention if you wanted to fix.
| Evaluate the frequency response of a linear system | ||
| `w -> C*((iw*im -A)^-1)*B + D` | ||
| `w -> C*((iw*im*I - A)^-1)*B + D` |
There was a problem hiding this comment.
I was more thinking of the w -> ... iw ... in my comment, I assume this should be w->...w...? I added the I since I thought maybe that is where the iw came from?
There was a problem hiding this comment.
But yeah, not really related (and not very important) so can fix it some other time.
this is convenient in many places where functions that take either systems of gain matrices.