Fix occasional problems with solve not including endpoint
#632
Conversation
|
This is an automated message.
|
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
+ Coverage 86.69% 86.75% +0.06%
==========================================
Files 31 31
Lines 3240 3255 +15
==========================================
+ Hits 2809 2824 +15
Misses 431 431
Continue to review full report at Codecov.
|
| # This will be called on plot(lsim(sys, args...)) | ||
| @recipe function simresultplot(r::SimResult; plotu=false) | ||
| ny, nu = r.ny, r.nu | ||
| @recipe function simresultplot(r::SimResult; plotu=false, plotx=false) |
There was a problem hiding this comment.
Are these keywords documented somewhere? Cause now that we have plotrecipes for types (and not bound to specific plotting function) it will be harder to make good documentation? Or can we just bind documentation to the plot function? Seems messy to me.
There was a problem hiding this comment.
No they can't really be documented anywhere other than in the general docs or perhaps docs of lsim. I'll add a note in the lsim docstring
Due to numerical rounding issues,
OrdinaryDiffEq.solvesometimes fails to include the last time point and thenlsimfails due to trying to access the solution out of bounds. This PR extends the time range by half a sample time to make sure the last time point is available.This PR also adds an option to plot the states when plotting a
SimResult