Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow two consecutive whitespaces as missingstring #743

Closed
jfb-h opened this issue Sep 25, 2020 · 1 comment · Fixed by #747
Closed

Allow two consecutive whitespaces as missingstring #743

jfb-h opened this issue Sep 25, 2020 · 1 comment · Fixed by #747

Comments

@jfb-h
Copy link

jfb-h commented Sep 25, 2020

See https://discourse.julialang.org/t/whitespace-as-missingstring-in-csv-file/47245
quinnj added a commit that referenced this issue Oct 7, 2020
@quinnj
Check missingstrings for space/tab for setting Parsers Options
34f61c5 
Fixes #743. In this issue, Parsers.jl was correctly validating inputs
and throwing an error because the sentinel values contained whitespace
characters. The fix then, as implemented in this PR, is to check
user-provided missingstrings if they contain space or tab and if so,
disable leading/trailing whitespace trimming.
@quinnj quinnj mentioned this issue Oct 7, 2020
Merged
@quinnj
Copy link
Member

quinnj commented Oct 7, 2020

Thanks for reporting; fix is up: #747

quinnj added a commit that referenced this issue Oct 8, 2020
@quinnj
Check missingstrings for space/tab for setting Parsers Options (#747)
9f6ef10 
* Check missingstrings for space/tab for setting Parsers Options

Fixes #743. In this issue, Parsers.jl was correctly validating inputs
and throwing an error because the sentinel values contained whitespace
characters. The fix then, as implemented in this PR, is to check
user-provided missingstrings if they contain space or tab and if so,
disable leading/trailing whitespace trimming.

* Fix

* fix compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check missingstrings for space/tab for setting Parsers Options JuliaData/CSV.jl
2 participants
@quinnj @jfb-h