Drop redundant convert(Union{T, Missing/Nothing}, x) methods
#396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fallback defined in Base calls `convert(T, x)`, giving the same result, and these methods cause invalidations.
bkamins
approved these changes
Sep 25, 2022
Member
bkamins
left a comment
bkamins
left a comment
There was a problem hiding this comment.
Do we have tests covering these dropped cases?
Member
Author
|
Actually it seems it was only tested indirectly. I've added tests. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback defined in Base calls
convert(T, x), giving the same result, and these methods cause invalidations.