From c70717311ba54002794182bf11147f26475ae689 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bogumi=C5=82=20Kami=C5=84ski?= Date: Tue, 13 Oct 2020 12:52:23 +0200 Subject: [PATCH] add comments from the review --- Project.toml | 2 +- src/dataframe/dataframe.jl | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/Project.toml b/Project.toml index a36eeb95c0..f4fb5ae092 100644 --- a/Project.toml +++ b/Project.toml @@ -44,5 +44,5 @@ Missings = "0.4.2" PooledArrays = "0.5" Reexport = "0.1, 0.2" SortingAlgorithms = "0.1, 0.2, 0.3" -Tables = "1" +Tables = "1.1" TableTraits = "0.4, 1" diff --git a/src/dataframe/dataframe.jl b/src/dataframe/dataframe.jl index 47a919edfa..56192d14a5 100644 --- a/src/dataframe/dataframe.jl +++ b/src/dataframe/dataframe.jl @@ -17,15 +17,11 @@ DataFrame(pairs::Pair{Symbol,<:Any}...; makeunique::Bool=false, copycols::Bool=t DataFrame(pairs::Pair{<:AbstractString,<:Any}...; makeunique::Bool=false, copycols::Bool=true) DataFrame(pairs::AbstractVector{<:Pair}; makeunique::Bool=false, copycols::Bool=true) -DataFrame() # an empty DataFrame -DataFrame(column_eltypes::AbstractVector, names::AbstractVector{Symbol}, - nrows::Integer=0; makeunique::Bool=false) -DataFrame(column_eltypes::AbstractVector, names::AbstractVector{<:AbstractString}, - nrows::Integer=0; makeunique::Bool=false) DataFrame(ds::AbstractDict; copycols::Bool=true) DataFrame(table; makeunique::Bool=false, copycols::Bool=true) DataFrame(::Union{DataFrame, SubDataFrame}; copycols::Bool=true) DataFrame(::GroupedDataFrame; keepkeys::Bool=true) +DataFrame() # an empty DataFrame ``` # Arguments