Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Basic Usage of Transformation Functions #2907

Closed
wants to merge 37 commits into from
Closed

Updated Basic Usage of Transformation Functions #2907

wants to merge 37 commits into from

Conversation

nathanrboyer
Copy link
Contributor

Documentation update related to #2866. This is a work in progress and my first pull request. Contributions welcome.

@nathanrboyer nathanrboyer changed the title Nb/docs transformations Updated Basic Usage of Transformation Functions Oct 12, 2021
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
docs/src/man/basics.md Outdated Show resolved Hide resolved
@nathanrboyer nathanrboyer marked this pull request as draft October 13, 2021 16:11
@bkamins bkamins added this to the 1.x milestone Dec 2, 2022
@bkamins
Copy link
Member

bkamins commented Jul 4, 2023

@nathanrboyer - it is still a draft. Right?

@nathanrboyer
Copy link
Contributor Author

Yes, sorry. I just picked up working on it again. I was hoping it wouldn't alert you yet. Should I avoid git push to my fork until I'm finished?

@bkamins
Copy link
Member

bkamins commented Jul 5, 2023

No - pushing is OK. Then I will ignore changes in this PR until it is marked as ready for review. Thank you!

@nathanrboyer nathanrboyer marked this pull request as ready for review July 16, 2023 20:22
@nathanrboyer
Copy link
Contributor Author

nathanrboyer commented Jul 16, 2023

basics.md contains the only content changes.
notes.md contains questions I had while writing. The answers to some of these questions should be added to the documentation or to pull requests.
The other changed files should be discarded. I will need help figuring out the correct Git process to get this branch compatible again with master.
Feedback and reorganization welcome, thanks!

notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
notes.md Show resolved Hide resolved
@bkamins
Copy link
Member

bkamins commented Jul 16, 2023

I answered all your questions in notes.md.

What I think will be simplest for you is to create a new branch from current main and make a new PR (later we will close this one and just work on a new one). This will be least work on your side I think. In that new PR please include only the things that should be merged (and we can use this PR of discussion on things you want to ask)

@nathanrboyer nathanrboyer closed this by deleting the head repository Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants