Use global system RNG #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system that gets rid of about 100ms of package load time.
Before:
After:
My understanding is that the global RNG is thread-safe (and thread-local) since Julia 1.3, which is the min Julia version for this package, so I don't think there is actually any need for this package specific thread-local RNG creation, right? See https://github.com/JuliaLang/julia/blob/master/HISTORY.md#multi-threading-changes-5.