Skip to content

Conversation

@davidanthoff
Copy link
Contributor

On my system that gets rid of about 100ms of package load time.

Before:

348.6 ms  SentinelArrays 31.04% compilation time

After:

242.6 ms  SentinelArrays

My understanding is that the global RNG is thread-safe (and thread-local) since Julia 1.3, which is the min Julia version for this package, so I don't think there is actually any need for this package specific thread-local RNG creation, right? See https://github.com/JuliaLang/julia/blob/master/HISTORY.md#multi-threading-changes-5.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 95.38% // Head: 95.35% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (1e9e13d) compared to base (7270ee7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   95.38%   95.35%   -0.03%     
==========================================
  Files           4        4              
  Lines         996      990       -6     
==========================================
- Hits          950      944       -6     
  Misses         46       46              
Impacted Files Coverage Δ
src/SentinelArrays.jl 91.72% <100.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@quinnj quinnj merged commit 9627b18 into JuliaData:main Sep 26, 2022
@davidanthoff davidanthoff deleted the system-rng branch September 26, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants