-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase package version to v1.4.2 #110
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 69.12% 69.45% +0.32%
==========================================
Files 7 7
Lines 910 910
==========================================
+ Hits 629 632 +3
+ Misses 281 278 -3 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Fixed tests on Julia v1.0 (inference failure, disabled type inference check on v1.0 for one test). All fine on Julia >=v1.6, we could consider dropping v1.0-support in the future. |
Fixes #108 (for non-developers :-) ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I agree that there should be a release to silence the warnings.
Good to merge from my side. |
Thanks! |
Whoops, I messed up, it seems - Project.toml had already been at v1.4.2 and I increased to v1.4.3 now, so Registrator is not happy: |
@andyferris could you trigger Registrator on 5fd8ff2, to register v1.4.2, and then re-trigger it on 874ad06 to register v1.4.3 after? Sorry again for the mess. |
No no - don't be sorry, I do the same thing all the time :) Hopefully it's good now |
Thanks @andyferris ! :-) |
@dmbates / @andyferris Could we tag a new release? The compiler warnings fixed in #107 are starting to get annoying. :-)