Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase package version to v1.4.2 #110

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Conversation

oschulz
Copy link
Contributor

@oschulz oschulz commented Mar 28, 2023

@dmbates / @andyferris Could we tag a new release? The compiler warnings fixed in #107 are starting to get annoying. :-)

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.32 🎉

Comparison is base (5fd8ff2) 69.12% compared to head (743a878) 69.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   69.12%   69.45%   +0.32%     
==========================================
  Files           7        7              
  Lines         910      910              
==========================================
+ Hits          629      632       +3     
+ Misses        281      278       -3     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oschulz
Copy link
Contributor Author

oschulz commented Mar 28, 2023

Fixed tests on Julia v1.0 (inference failure, disabled type inference check on v1.0 for one test). All fine on Julia >=v1.6, we could consider dropping v1.0-support in the future.

@oschulz
Copy link
Contributor Author

oschulz commented Mar 28, 2023

Fixes #108 (for non-developers :-) ).

Copy link
Contributor

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I agree that there should be a release to silence the warnings.

@oschulz
Copy link
Contributor Author

oschulz commented Mar 28, 2023

Good to merge from my side.

@andyferris andyferris merged commit 874ad06 into JuliaData:main Mar 28, 2023
@andyferris
Copy link
Member

Thanks!

@oschulz
Copy link
Contributor Author

oschulz commented Mar 29, 2023

Whoops, I messed up, it seems - Project.toml had already been at v1.4.2 and I increased to v1.4.3 now, so Registrator is not happy:

#110 (review)

@oschulz
Copy link
Contributor Author

oschulz commented Mar 30, 2023

@andyferris could you trigger Registrator on 5fd8ff2, to register v1.4.2, and then re-trigger it on 874ad06 to register v1.4.3 after?

Sorry again for the mess.

@andyferris
Copy link
Member

No no - don't be sorry, I do the same thing all the time :) Hopefully it's good now

@oschulz
Copy link
Contributor Author

oschulz commented Mar 31, 2023

Thanks @andyferris ! :-)

@oschulz oschulz deleted the new-release branch March 31, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants