WIP: Add InlineStrings serialization #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wynand
force-pushed
the
wy/inline-string-serialization
branch
from
dde95de
to
7117bc6
Compare
Wynand
force-pushed
the
wy/inline-string-serialization
branch
from
7117bc6
to
f6bb722
Compare
No problem! I should mention that all the serialization logic here was figured out by @iamed2 and not by me, so they should get all the credit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds serialization (and deserialization) of InlineStrings, as well as a test to make sure they're compatible with each other