Skip to content

Conversation

@ExpandingMan
Copy link
Contributor

The AbstractArray fallback for Base.isassigned relies on a try/catch and is unbelievably slow.

This PR adds a method for StringArray to avoid this along with some tests.

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #95 (4723c23) into main (40c0d5e) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   76.39%   76.47%   +0.07%     
==========================================
  Files           2        2              
  Lines         627      629       +2     
==========================================
+ Hits          479      481       +2     
  Misses        148      148              
Impacted Files Coverage Δ
src/WeakRefStrings.jl 78.26% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c0d5e...4723c23. Read the comment docs.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@quinnj quinnj merged commit 76c46a8 into JuliaData:main Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants