missing interface element #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
approved these changes
Apr 14, 2022
Member
quinnj
left a comment
quinnj
left a comment
There was a problem hiding this comment.
Thanks @lawless-m! Sorry for the slow review here!
Member
|
Hmmmm.....the test failures look suspicious, but I don't see how this PR would have changed anything related to query results suddenly starting to fail. I'll merge for now, but will make a note to investigate what's going on there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getconnection is missing, which is part of the DBInterface
used by executemany, missing in ODBC
see open issue on DBInterface
JuliaDatabases/DBInterface.jl#43