isdefined check in locals() #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Presumably this fixed an error, do you have a reproducer? |
Member
Author
|
Yeah. Added a test... |
timholy
reviewed
May 30, 2020
Member
|
Looks like you've got a Julia 1.0-specific bug, otherwise this is good to go. (If you edit it note I added a commit that fixed a different problem.) |
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 87.68% 87.70% +0.02%
==========================================
Files 11 11
Lines 2005 2009 +4
==========================================
+ Hits 1758 1762 +4
Misses 247 247
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to best test this though.Now with tests.