check if symbol is defined before trying to access it #440
Conversation
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
Why aren't these symbols wrapped into QuoteNodes ... ?
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
- Coverage 89.37% 85.46% -3.91%
==========================================
Files 12 12
Lines 2268 2250 -18
==========================================
- Hits 2027 1923 -104
- Misses 241 327 +86
Continue to review full report at Codecov.
|
|
Actually, this is more subtle than I initially thought. This essentially kicks the can down the road; suppose there is an object named I almost wonder if we should delete those Symbol lookup methods (that breaks a lot of tests, but maybe they can all be addressed individually). They might essentially correspond to cases where we fail to |
`evaluate_call_recurse!` calls `maybe_evaluate_builtin`, and if
that doesn't return a `Some{Any}`, it uses the output as the
new `call_expr`. The next thing it does is look up the args.
Consequently, to avoid double-lookup, our expansion of `invoke` should
return the non-looked-up arguments.
Fixes #441
Closes #440
`evaluate_call_recurse!` calls `maybe_evaluate_builtin`, and if
that doesn't return a `Some{Any}`, it uses the output as the
new `call_expr`. The next thing it does is look up the args.
Consequently, to avoid double-lookup, our expansion of `invoke` should
return the non-looked-up arguments.
Fixes #441
Closes #440
3 participants
Fixes https://discourse.julialang.org/t/debugger-stops-without-hitting-a-breakpoint/50378.