Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old atan2 tests #140

Merged
merged 1 commit into from
Dec 25, 2019
Merged

remove old atan2 tests #140

merged 1 commit into from
Dec 25, 2019

Conversation

oxinabox
Copy link
Member

I think when we switch atan2 tests to use frule_test and rrule_test we forgot to delete the old bad tests.

I think this is now tested well using

@testset "binary trig ($f)" for f in (hypot, atan)
rng = MersenneTwister(123456)
x, Δx, x̄ = 10randn(rng, 3)
y, Δy, ȳ = randn(rng, 3)
Δz = randn(rng)
frule_test(f, (x, Δx), (y, Δy))
rrule_test(f, Δz, (x, x̄), (y, ȳ))
end

@oxinabox oxinabox merged commit d39e82c into master Dec 25, 2019
@YingboMa YingboMa deleted the ox/nooldatan2tests branch December 25, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants