Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic documentation #6

Merged
merged 7 commits into from
Apr 10, 2019
Merged

Add basic documentation #6

merged 7 commits into from
Apr 10, 2019

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Apr 2, 2019

This is mostly copying what's in comments in the code into actual doc files along with the existing docstrings. I've also added a couple of basic docstrings.

This is mostly copying what's in comments in the code into actual doc
files along with the existing docstrings. I've also added a couple of
basic docstrings.
`nothing` is returned.

See also: [`rrule`](@ref)
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frule returns a tuple of AbstractRules - one for each of the function's outputs.

Similarly, rrule returns a tuple of AbstractRules, one for each of the function's inputs.

If the returned tuple would only contain a single AbstractRule, the single AbstractRule may be returned directly (basically just matching Julia's return behavior).

end
return fx, dx
end
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of thing definitely belongs in an advanced usage section :)

@jrevels
Copy link
Member

jrevels commented Apr 4, 2019

Thanks for kicking the tires here! I'll add some commits to this branch as well; I've settled on a notation for certain parts of these, so I'll update frule/rrule docstrings to use that

@jrevels jrevels merged commit b3f66e3 into master Apr 10, 2019
@jrevels jrevels deleted the aa/actual-docs branch April 10, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants