Deprecate One()
#357
Deprecate One()
#357
Conversation
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
- Coverage 90.03% 86.64% -3.40%
==========================================
Files 14 13 -1
Lines 542 539 -3
==========================================
- Hits 488 467 -21
- Misses 54 72 +18
Continue to review full report at Codecov.
|
nickrobinson251
left a comment
nickrobinson251
left a comment
There was a problem hiding this comment.
confused by one test, but otherwise LGTM
| sy = @SVector [3, 4] | ||
|
|
||
| # Test that @scalar_rule and `One()` play nice together, w.r.t broadcasting | ||
| @inferred frule((ZeroTangent(), sx, sy), very_nice, 1, 2) |
There was a problem hiding this comment.
what is this testing? it doesn't appear to be using One anywhere
There was a problem hiding this comment.
I think it is testing that One() * sx is type stable?
| @test frule((nothing, nothing, 5.0), Core._apply, dummy_identity, 4.0) == (4.0, 5.0) | ||
|
|
||
| @testset "broadcasting One" begin | ||
| @testset "broadcasting true" begin |
There was a problem hiding this comment.
How does this name and comments relate to the @inferred test here?
There was a problem hiding this comment.
Maybe we don't need this test anymore?
|
Lets add a comment specificially about |
Done, please suggest a rephrasing if you think it's unclear. Also, could you please check this thread? #357 (comment) |
Co-authored-by: Lyndon White <oxinabox@ucc.asn.au>
First step towards #354