Skip to content

Make One, Zero, and DNE inferable when broadcasting with StaticArrays #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2020
Merged

Make One, Zero, and DNE inferable when broadcasting with StaticArrays #96

merged 4 commits into from
Jan 13, 2020

Conversation

@YingboMa
Copy link
Member

@YingboMa YingboMa commented Jan 13, 2020

It also saves computation since

goo(x) = (One.() .* x) .+ (One.() .* x)

is now the same as

goo(x) = (One() .* x) .+ (One() .* x)

.

@YingboMa YingboMa requested a review from oxinabox January 13, 2020 21:22
nickrobinson251
nickrobinson251 reviewed Jan 13, 2020
View reviewed changes
oxinabox
oxinabox reviewed Jan 13, 2020
View reviewed changes
@YingboMa @oxinabox
Update test/rules.jl
aa107f8 
Co-Authored-By: Lyndon White <oxinabox@ucc.asn.au>
@YingboMa YingboMa merged commit c782e40 into master Jan 13, 2020
@YingboMa YingboMa deleted the myb/infer branch January 13, 2020 22:04
@oxinabox oxinabox mentioned this pull request Jan 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickrobinson251 nickrobinson251 nickrobinson251 left review comments

@oxinabox oxinabox oxinabox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YingboMa @oxinabox @nickrobinson251